This repository has been archived by the owner on Aug 10, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 92
Cto 222 mixpanel gdpr #90
Open
brizido
wants to merge
83
commits into
jkrall:master
Choose a base branch
from
Seedrs:CTO-222-mixpanel-gdpr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All methods except for events are now ignored.
Update mixpanel implementation
Update google analytics to the new Universal Analytics version
Add alias identity to mixpanel module
Fix arguments' order for google analytics tracking method.
send event action as string "undefined" when action is not defined
Intercom update async request
The reset method should be implemented when the service provides some kind of clean up task to be executed when the user logs out.
Add reset method
We need to double escape the backslash character because the heredoc results in a escaped string. We can't disable the interpolation and escaping from the heredoc because we're using interpolation to insert the mixpanel token.
Fix mixpanel lib
Update AdRoll code
Previous update did not include changes that I thought were superficial
Check if intercom is defined before calling it
Add segment
Ga label update
We're going to use just the intercom-rails gem to track only the events needed for intercom
Remove intercom integration
The way to ignore the referrer is to set our own domain as the referrer.
Ignore referrer when cookie for that is present
Fixing issue where visitors where not being tracked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.